<html>
<head><meta charset="utf-8"><title>backport #86368 · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/backport.20.2386368.html">backport #86368</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="246861934"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/backport%20%2386368/near/246861934" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/backport.20.2386368.html#246861934">(Jul 22 2021 at 15:19)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> <span class="user-mention" data-user-id="124287">@mw</span> it looks like <a href="https://github.com/rust-lang/rust/pull/86368">https://github.com/rust-lang/rust/pull/86368</a> is going to require pulling in other PRs I think or a more involved backport; can we assign someone to take a look and try and prepare a dedicated backport PR?</p>



<a name="246861949"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/backport%20%2386368/near/246861949" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/backport.20.2386368.html#246861949">(Jul 22 2021 at 15:19)</a>:</h4>
<p>cc <span class="user-mention" data-user-id="125250">@Wesley Wiser</span> as well</p>



<a name="246862383"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/backport%20%2386368/near/246862383" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/backport.20.2386368.html#246862383">(Jul 22 2021 at 15:23)</a>:</h4>
<p>I can work with @mw to make sure we get a backport for this. When do you need it by <span class="user-mention" data-user-id="116122">@simulacrum</span>?</p>



<a name="246862415"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/backport%20%2386368/near/246862415" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/backport.20.2386368.html#246862415">(Jul 22 2021 at 15:23)</a>:</h4>
<p>"Soon".... ideally I think we'd aim for by Monday morning ET, roughly.</p>



<a name="246866154"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/backport%20%2386368/near/246866154" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/backport.20.2386368.html#246866154">(Jul 22 2021 at 15:51)</a>:</h4>
<p>The backport indeed isn't straightforward without <a href="https://github.com/rust-lang/rust/pull/85834">https://github.com/rust-lang/rust/pull/85834</a>.</p>



<a name="246866823"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/backport%20%2386368/near/246866823" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/backport.20.2386368.html#246866823">(Jul 22 2021 at 15:56)</a>:</h4>
<p>Do you want me to try and adapt the code with a minimal diff?</p>



<a name="246867654"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/backport%20%2386368/near/246867654" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/backport.20.2386368.html#246867654">(Jul 22 2021 at 16:03)</a>:</h4>
<p><span class="user-mention" data-user-id="124287">@mw</span> Do you feel it would be "safe" to just backport <a href="https://github.com/rust-lang/rust/issues/85834">#85834</a>?</p>



<a name="246867708"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/backport%20%2386368/near/246867708" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/backport.20.2386368.html#246867708">(Jul 22 2021 at 16:03)</a>:</h4>
<p>It landed a while ago and I don't think we had problems with it?</p>



<a name="246867893"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/backport%20%2386368/near/246867893" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/backport.20.2386368.html#246867893">(Jul 22 2021 at 16:04)</a>:</h4>
<p>I think I would prefer a straight backport of another PR to alterations this late, since those would get less testing than nightly has over the last several weeks</p>



<a name="246867923"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/backport%20%2386368/near/246867923" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/backport.20.2386368.html#246867923">(Jul 22 2021 at 16:05)</a>:</h4>
<p>But I'm not sure how risky 85834 seems; I'm not very familiar with that code.</p>



<a name="246932397"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/backport%20%2386368/near/246932397" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/backport.20.2386368.html#246932397">(Jul 23 2021 at 03:52)</a>:</h4>
<p>Yes, <a href="https://github.com/rust-lang/rust/issues/85834">#85834</a> applies cleanly and is nicely self-contained. I think that's the best option.</p>



<a name="246932437"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/backport%20%2386368/near/246932437" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/backport.20.2386368.html#246932437">(Jul 23 2021 at 03:53)</a>:</h4>
<p>Backport PR: <a href="https://github.com/rust-lang/rust/pull/87393">https://github.com/rust-lang/rust/pull/87393</a></p>



<a name="247293712"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/backport%20%2386368/near/247293712" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/backport.20.2386368.html#247293712">(Jul 27 2021 at 04:41)</a>:</h4>
<p>thanks to <span class="user-mention" data-user-id="124287">@mw</span> and <span class="user-mention" data-user-id="116122">@simulacrum</span> for following through on this!</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>